[java] SpotBugs exclude DMI_HARDCODED_ABSOLUTE_FILENAME - #14597
Merged
pujagani merged 2 commits intoDec 5, 2024
Conversation
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Contributor
PR Code Suggestions ✨No code suggestions found for the PR. |
mk868
force-pushed
the
safari-DMI_HARDCODED_ABSOLUTE_FILENAME
branch
from
October 23, 2024 08:33
c5ef9ba to
3a3dfb9
Compare
…chPreviewDriverService
mk868
force-pushed
the
safari-DMI_HARDCODED_ABSOLUTE_FILENAME
branch
from
November 14, 2024 08:33
3a3dfb9 to
5fd8265
Compare
Contributor
Author
|
Hi, can we push forward this PR? |
pujagani
approved these changes
Dec 5, 2024
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Description
As described in this comment, SpotBugs found some additional bugs in the code.
In this PR I fix part of the found problems.
SpotBugs errors:
documentation
Solution:
Exclude these class from SpotBugs checks, as it is already done for
org.openqa.selenium.safari.SafariDriverService.Motivation and Context
Fixing the actual problems is necessary before enabling full SpotBugs analysis, in order to not break the build.
Types of changes
Checklist
PR Type
Bug fix
Description
DMI_HARDCODED_ABSOLUTE_FILENAMEbug pattern in theSafariTechPreviewDriverServiceclass.SafariDriverServiceclass.Changes walkthrough 📝
spotbugs-excludes.xml
Exclude DMI_HARDCODED_ABSOLUTE_FILENAME forSafariTechPreviewDriverServicejava/spotbugs-excludes.xml
DMI_HARDCODED_ABSOLUTE_FILENAMEbug pattern.SafariTechPreviewDriverServiceclass.