[dotnet] Workaround using pre-processor directive - #14499
Merged
Conversation
Contributor
PR Reviewer Guide 🔍
|
Contributor
PR Code Suggestions ✨
|
M1troll
pushed a commit
to M1troll/selenium
that referenced
this pull request
May 14, 2025
* [dotnet] Workaround using pre-processor directive * Fix formatting? * Fix formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Description
Bazel understands
NET8_0, but doesn't understandNET8_0_OR_GREATER.Motivation and Context
We want to use pre-processor directives.
Types of changes
Checklist
PR Type
Bug fix, Enhancement
Description
NET8_0_OR_GREATERpre-processor directive in the Bazel build configuration to ensure compatibility with Bazel's understanding of .NET versioning.NET8_0_OR_GREATER.Changes walkthrough 📝
BUILD.bazel
Add pre-processor directive for .NET version compatibilitydotnet/src/webdriver/BUILD.bazel
NET8_0_OR_GREATERto thedefinessection.directives.