Skip to content

fix type errors for input_device and file_detector - #14459

Merged
harsha509 merged 6 commits into
SeleniumHQ:trunkfrom
Delta456:mypy_fix
Sep 10, 2024
Merged

fix type errors for input_device and file_detector#14459
harsha509 merged 6 commits into
SeleniumHQ:trunkfrom
Delta456:mypy_fix

Conversation

@Delta456

Copy link
Copy Markdown
Member

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR for type errors for input_device.py and file_detector.py as seen in https://github.com/SeleniumHQ/selenium/actions/runs/10626264126/job/29457778562

@CLAassistant

CLAassistant commented Aug 30, 2024

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@Delta456
Delta456 marked this pull request as ready for review August 31, 2024 16:53
@pujagani pujagani added the python label Sep 2, 2024
@codecov

codecov Bot commented Sep 2, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.68%. Comparing base (8fc4299) to head (d87ba2c).
Report is 1 commits behind head on trunk.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #14459      +/-   ##
==========================================
+ Coverage   57.65%   57.68%   +0.02%     
==========================================
  Files          89       89              
  Lines        5571     5579       +8     
  Branches      236      240       +4     
==========================================
+ Hits         3212     3218       +6     
+ Misses       2123     2121       -2     
- Partials      236      240       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harsha509 harsha509 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Delta456 !

@harsha509
harsha509 merged commit 49f2f76 into SeleniumHQ:trunk Sep 10, 2024
@harsha509

Copy link
Copy Markdown
Contributor

Congratulations on your first contribution to Selenium @Delta456 🎉 🎉 🎉 !

@Delta456
Delta456 deleted the mypy_fix branch September 10, 2024 15:35
@titusfortner titusfortner added C-py Python Bindings and removed python labels Mar 30, 2025
M1troll pushed a commit to M1troll/selenium that referenced this pull request May 14, 2025
)

Co-authored-by: Sri Harsha <12621691+harsha509@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-py Python Bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants