fix type errors for input_device and file_detector - #14459
Merged
Conversation
Delta456
marked this pull request as ready for review
August 31, 2024 16:53
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #14459 +/- ##
==========================================
+ Coverage 57.65% 57.68% +0.02%
==========================================
Files 89 89
Lines 5571 5579 +8
Branches 236 240 +4
==========================================
+ Hits 3212 3218 +6
+ Misses 2123 2121 -2
- Partials 236 240 +4 ☔ View full report in Codecov by Sentry. |
harsha509
approved these changes
Sep 10, 2024
Contributor
|
Congratulations on your first contribution to Selenium @Delta456 🎉 🎉 🎉 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist
PR for type errors for
input_device.pyandfile_detector.pyas seen in https://github.com/SeleniumHQ/selenium/actions/runs/10626264126/job/29457778562