fix type errors for service.py, cdp.py, webelement.py and remote_connection.py - #14448
Conversation
…te_connection.py`
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
…te_connection.py` (SeleniumHQ#14448) * fix type errors for `service.py`, `cdp.py`, `webelement.py` and `remote_connection.py` * remove raise error --------- Co-authored-by: Sri Harsha <12621691+harsha509@users.noreply.github.com>
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Fixes the mypy type errors for multiple files.
Types of changes
Checklist
PR Type
Bug fix
Description
castfor type hinting.Nonevalues and appropriate error handling in service-related files.remote_connection.pyto usegetdefaulttimeout.send_keysmethod inwebelement.pyhandles values as tuples.Changes walkthrough 📝
cdp.py
Add type annotations for event channelspy/selenium/webdriver/common/bidi/cdp.py
senderandreceivervariables.service.py
Fix type errors and add type castingpy/selenium/webdriver/common/service.py
castfor type hinting onlog_output.Nonepath instartmethod.castforstdoutandstderrin subprocess.remote_connection.py
Update timeout initialization for remote connectionpy/selenium/webdriver/remote/remote_connection.py
getdefaulttimeout.webelement.py
Fix type error in send_keys methodpy/selenium/webdriver/remote/webelement.py
valueto a tuple forsend_keysmethod.service.py
Add type annotations and remove type ignorepy/selenium/webdriver/webkitgtk/service.py
DEFAULT_EXECUTABLE_PATH.service.py
Add executable check and remove type ignorepy/selenium/webdriver/wpewebkit/service.py