Skip to content

Version check crashes server when there is a request problem to github #479

Description

@Jared-Sprague

Not sure why, but sometimes the request to github to get the version errors out, then crashes the server. I added a bunch of error handling, but it's still happening.

Here are the exceptions:

[11/20/2016 19:09:55.000] [ERROR] Error: connect ECONNREFUSED 13.93.219.88:443
    at Object.exports._errnoException (util.js:907:11)
    at exports._exceptionWithHostPort (util.js:930:20)
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1077:14)
[11/20/2016 19:01:21.488] [ERROR] Error: connect ETIMEDOUT 13.93.219.88:443
    at Object.exports._errnoException (util.js:907:11)
    at exports._exceptionWithHostPort (util.js:930:20)
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1077:14)
[11/20/2016 18:55:37.489] [ERROR] Error: read ECONNRESET
    at exports._errnoException (util.js:907:11)
    at TLSWrap.onread (net.js:557:26)

I temporarily turned off version checking until we figure out how to make it not crash the server when there is a connection error to github, or come up with a better method for version checking, that doesn't rely on github being up.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions