Hotfix/464 broken anchor links - #465
Conversation
|
What needs to happen to merge this pull? |
|
A review from maintainers. :D Ping @SassDoc/owners. |
|
I tried to wrap my head around this some time ago, and was not convinced this is the right way, there's a missing brick on why it is this way. |
|
been a few months since I wrote this code, but I recall being aware my solution was somewhat 'baked' - i.e effectivly baking a new property into the annotation object is far from elegant. Would be more preferable to have a reference to the parent scope so we could access the grouping property directly rather than adding/removing as we go. I was also aware I didn't want to completely break existing theme templates... My stuff is ugly, but it works - and it got my documentation working with a locally patched version of the library. |
|
Hey I’m kind of busy right now, but this is on my radar. I’ll try to check this next week. |
| aliasedItem.aliased = []; | ||
| } | ||
|
|
||
| if (!Array.isArray(aliasedItem.aliasedgroup)) { |
There was a problem hiding this comment.
We should probably use aliasedGroup to respect camelCase conventions?
|
@SassDoc/owners The code looks simply enough to me. Can someone review it as well? I might lack a bit of context on this part of the code base. |
|
|
||
| let alias = item.alias; | ||
| let name = item.context.name; | ||
| var aliasGroup = item.group; |
|
I'm out and about today, but I'll make the changes to the camelCasing this |
|
Is there any progress on this request? the problem still exists.. |
|
There's a few changes requested though. |
|
I understand that there are many requests and i didn't mean to be impatient. It's just that this pull request is open for almost 2 years now and no further progress was reported. just wanted to know if there are any news because we handle large projects with sassdoc and grouping is necessary to keep our documentary organized and this issue makes the linking kind of useless. |
Same for me, I heavily rely on groups in a very large codebase. What can I do to help get this over the finish line? Is the hold-up just camel-casing and changing a |
|
Hello there. 👋 I am no longer maintaining SassDoc, nor do I have time to invest in that project anymore. Unfortunately, I don’t think we have dedicated maintainers to take over, so the project is kind of frozen in time and place. I‘m sorry about this. |
|
Hey! On top of the PR comments, a quick rebasing / conflicts fixing needed to be done. I've pushed an up-to-date version of this PR in #567. @d13 any chance you can checkout the code from #567 and run it against your codebase to confirm this fixes the issue for you as well? Something like Since this was opened as a Cheers! |
|
Definitely. Happy to release a hotfix once it‘s merged. |
|
Released with sassdoc@2.7.4 and sassdoc-theme-default@2.8.5! |
7 participants
has fixes for broken anchor references when annotation link to items in other @group's