[RFR] Switch to ESlint

[pascalduez]

• Waiting for comma in template string right after ${} causes comma-spacing babel/babel-eslint#31
• space-before-function-parentheses or space-before-function-paren does not seem to work
• A few fixes left

[valeriangalliat]

Awesome work!

Feels really good to remove all these ignore comments.

[pascalduez]

Plus it's driving out much more possible issues than JShint.

@valeriangalliat feel free to hack in if you see something.

[KittyGiraudel]

Terrific. Only the tests to fix before merging. :)

[pascalduez]

Something to discuss:

src/cli.js
  45:6  error  Don't use process.exit(); throw an error instead  no-process-exit
  48:4  error  Don't use process.exit(); throw an error instead  no-process-exit

http://eslint.org/docs/rules/no-process-exit.html

I guess we can mute this rule.

[KittyGiraudel]

Any reason we do exit instead of throwing an error?

[valeriangalliat]

Any reason we do exit instead of throwing an error?

To control the exit code.

+1 to mute the rule, it's not meaningful in the CLI, it's only relevant inside the library code (and we don't exit from the library).

[valeriangalliat]

searchForMatches is calling the isAnnotatedByHand function passed as a parameter. It don't uses the upper scope declared function (though the calling code is actually passing it this very function, see searchForMatches calls).

[pascalduez]

Yeah, I removed my comment, just realized the isAnnotatedByHand.bind(...)
Renaming the parameter into isAnnotatedByHandProxy

[coveralls]

Coverage remained the same at 94.09% when pulling ab89646 on eslint into 81ec9e3 on develop.

[pascalduez]

So this is now Ready for review :-)

We are using all of ESlint default rules, overriding just the few ones we "don't agree" with.
There's also a couple of style rules added.
I personally like this approach.

Another option is not to use any base rules with --reset and set all the rules our self.

If you see something that should be added ?

[valeriangalliat]

I like it as is, okay to merge. 👍

[coveralls]

Coverage remained the same at 94.09% when pulling 1aaed23 on eslint into 81ec9e3 on develop.

[pascalduez]

What about moving to adding a space between function declaration name and params.
Which brings us closer to standard

function whatever (foo, bar) { ... } 

[valeriangalliat]

I'm all for following standard. I'm also okay with semistandard which is basically like standard but with semicolons (and thus will be more friendly with our codebase).

[coveralls]

Coverage remained the same at 94.09% when pulling b8c4746 on eslint into 81ec9e3 on develop.

[coveralls]

Coverage remained the same at 94.09% when pulling b8c4746 on eslint into 81ec9e3 on develop.