Proper behavior when the default theme is missing - #207
Merged
Conversation
Member
|
Can we merge this or? |
Member
|
Would be better to have @valeriangalliat confirmation, but I think it's clean, we've been discussing it extensively, and I also tested it myself. |
Member
Author
|
Everything is okay, you can merge. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throw an
Errorinstance so it's not ignored in the promises flow, and allow to pass the--themeoption tocfgfunction so there's no need for two passes to resolve the theme.