Skip to content

Added the ability to define tracking, either through googleAnalytics or trackingCode - #10

Merged
KittyGiraudel merged 2 commits into
developfrom
tracking-feature
Oct 12, 2014
Merged

Added the ability to define tracking, either through googleAnalytics or trackingCode#10
KittyGiraudel merged 2 commits into
developfrom
tracking-feature

Conversation

@KittyGiraudel

Copy link
Copy Markdown
Member

@SassDoc/owners Please review.


Are we okay on key names (googleAnalytics and trackingCode)?

Or perhaps:

  • GAKey
  • GATrackingKey
  • googleAnalyticsTrackingKey

And:

  • tracking
  • trackingSnippet

Thoughts?

@valeriangalliat

Copy link
Copy Markdown
Member

googleAnalytics and trackingCode are fine to me.

@KittyGiraudel

Copy link
Copy Markdown
Member Author

@FWeinb, @pascalduez?

@FWeinb

FWeinb commented Oct 11, 2014

Copy link
Copy Markdown
Member

googleAnalytics and trackingCode 👍

@pascalduez

Copy link
Copy Markdown
Member

googleAnalytics and trackingCode are straightforward enough.

@KittyGiraudel

Copy link
Copy Markdown
Member Author

Perfect. Can one of you review the code to make sure it's okay? :)

@valeriangalliat

Copy link
Copy Markdown
Member

Not sure with the else if part… some websites use not only Google Analytics but a bunch other tracking systems. But in this case they can just put everything in the trackingCode anyway.

Otherwise everything is fine, you can merge (the above is an edge case anyway, at least for code documentation websites).

@KittyGiraudel

Copy link
Copy Markdown
Member Author

I'll make 2 separate if.

@KittyGiraudel

Copy link
Copy Markdown
Member Author

Okay, let's merge this on develop. There is a PR pending to add documentation to site, but we won't merge it until this goes live.

KittyGiraudel added a commit that referenced this pull request Oct 12, 2014
Added the ability to define tracking, either through googleAnalytics or trackingCode
@KittyGiraudel
KittyGiraudel merged commit e3c771a into develop Oct 12, 2014
@valeriangalliat

Copy link
Copy Markdown
Member

@hugogiraudel Maybe we need some kind of develop on sassdoc.github.io?

@KittyGiraudel

Copy link
Copy Markdown
Member Author

Might be interesting.

@KittyGiraudel
KittyGiraudel deleted the tracking-feature branch November 24, 2014 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants