Fixes OOM Errors - too high RAM usage by VAD - #1198
Merged
Merged
Conversation
This was referenced Dec 10, 2024
Closed
Collaborator
|
Thanks, for reference microsoft/onnxruntime#11627 BTW, there is still room for OOM on smaller ram systems caused by this: faster-whisper/faster_whisper/vad.py Lines 302 to 305 in 8327d8c the input here is (num_segments, 576) and num_segments depends on the audio length and it's unbounded, we should replace this with a for loop over num_segments with a large batch size (10k for example or the lowest number where we start to lose speed), this is helpful for very long audios
|
MahmoudAshraf97
approved these changes
Dec 12, 2024
This was referenced Dec 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1193 and #1169
VAD implementation consumes humongous memory amount [original Silero doesn't have this problem]
This PR should fix the OOM problem.
Alt solution could be removing
lru_cache.