Add logo to metadata collectors - #2
Open
kofzera wants to merge 4 commits into
Open
Conversation
Member
|
It would be good to have the same on the OIDC side to keep things consistent. |
kofzera
force-pushed
the
add_collector_metadata
branch
from
March 20, 2023 07:43
2ced137 to
8dd59fe
Compare
kofzera
changed the title
Member
|
LGTM; if you have tested this we should merge. |
Member
|
Any news on this? |
fix: prevent KeyError when error_url is missing
kofzera
force-pushed
the
add_collector_metadata
branch
2 times, most recently
from
May 9, 2023 06:20
4efe674 to
d0b1f6a
Compare
kofzera
force-pushed
the
add_collector_metadata
branch
2 times, most recently
from
May 10, 2023 10:38
e849ceb to
aa7eb31
Compare
kofzera
force-pushed
the
add_collector_metadata
branch
from
May 21, 2023 12:47
aa7eb31 to
9156529
Compare
kofzera
force-pushed
the
add_collector_metadata
branch
from
May 21, 2023 12:56
9156529 to
85ef6c5
Compare
|
@c00kiemon5ter We have made some improvements, tested this and it works for us. Feel free to merge this if you're happy with it. |
6 tasks
Also, to make this fully functional, IdentityPython/SATOSA#438 needs to be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.