Skip to content

ENH: adding name as a karg in Flight class #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gui-FernandesBR merged 3 commits into from
Nov 14, 2022
Merged

ENH: adding name as a karg in Flight class #293

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5b4857
ENH: adding name as a karg in Flight class
Gui-FernandesBR Nov 13, 2022
c37d95f
MAINT: modifying default name value
Gui-FernandesBR Nov 14, 2022
ca68cd8
MAINT: Update flight docs
Gui-FernandesBR Nov 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions rocketpy/Flight.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ class Flight:
Original rail length minus the distance measured from nozzle exit
to the lower rail button. It assumes the nozzle to be aligned with
the beginning of the rail.
Flight.name: str
Name of the flight.


Numerical Integration settings:
Expand Down Expand Up @@ -527,6 +529,7 @@ def __init__(
atol=6 * [1e-3] + 4 * [1e-6] + 3 * [1e-3],
timeOvershoot=True,
verbose=False,
name="Flight",
):
"""Run a trajectory simulation.

Expand Down Expand Up @@ -582,6 +585,8 @@ def __init__(
time in some cases. Default is True.
verbose : bool, optional
If true, verbose mode is activated. Default is False.
name : str, optional
Name of the flight. Default is "".
Comment thread
Gui-FernandesBR marked this conversation as resolved.
Outdated

Returns
-------
Expand All @@ -607,6 +612,7 @@ def __init__(
self.initialSolution = initialSolution
self.timeOvershoot = timeOvershoot
self.terminateOnApogee = terminateOnApogee
self.name = name

# Modifying Rail Length for a better out of rail condition
upperRButton = max(self.rocket.railButtons[0])
Expand Down