REL: v0.12.0 - Elliptical fins - #225
Conversation
…ter/RocketPy into enh/elliptical_fins
Class addFins updates: - Parameters: Now we have a new parameter "type", a string to set the type of the fins. - Span, Root and Tip parameters were removed and a dictionary was added. - Elliptical fins added
AddFins class optimized: - Repeated codes deleted - Roll geometry constant added to elliptical fins - Elliptical fins code finished
- Repeated codes deleted - Roll geometry constant added to elliptical fins - Elliptical fins code finished
…etrical Constant; testing
|
Please wait until the end of the day before merging. |
…otebook ENH: Add surface wind speeds, precipitation, clouds and hourly data to Environment Analysis
|
Everything seems good to me. @giovaniceotto any other problem or can we move forward? |
giovaniceotto
left a comment
giovaniceotto
left a comment
There was a problem hiding this comment.
There is a major issue with the Getting Started.html file for Matlab. Its rendering is completely bugged. I have spent a couple of hours trying to fix it with no success. This cannot be approved until this is fixed.
An image for perspective:
|
@Gui-FernandesBR, please review my changes, approve them if everything is all right and merge. |
Co-authored-by: Giovani Hidalgo Ceotto <ghceotto@gmail.com>
|
@giovaniceotto I'm still looking for an answer on the MATLAB problem. Meanwhile, is it possible to create tests for documentation or at list the matlab integration? |
|
All reviewers have approved, and all tests have passed. Time to merge. Then, it's time to create a new release. @Gui-FernandesBR should the general team or the outreach team do it? |
|
@Gui-FernandesBR, I have fixed the MATLAB documentation problem this morning in this commit: 68a5cfb No, there is no way to implement a test for the MATLAB integration as that would require a license. No, there is no straightforward way to create a test to check if the MATLAB getting started html is formatted correctly, unfortunately. But all is good for now! |
Gui-FernandesBR
changed the title
7 participants
Pull request type
Please check the type of change your PR introduces:
Pull request checklist
ReadMe, Docs and GitHub maintenance:
What is the new behavior?
I'm adding develop new Elliptical Fins to master branch so we can relase a new version of rocketpy project!
Does this introduce a breaking change?
Other information
Although conda forge isn't updated to v0.11.1 yet, that will not conflict with this new release.