Double Check Constructor/Destructors

[RobLoach]

https://github.com/raysan5/raylib/wiki/Using-raylib-with-Cpp#shared-gpu-resources-in-constructors-and-destructors

[RobLoach]

Reviewed all GPU/audio resource classes against the shared GPU resources guidelines. Here's what I found:

Well-implemented classes ✅

These correctly delete copy constructors/assignment, implement move semantics that null the source, and guard Unload() with a validity check:

• Texture / TextureUnmanaged — guards with id != 0
• Shader / ShaderUnmanaged — guards with locs != nullptr
• Font — guards with baseSize != 0
• Model — guards with meshes != nullptr || materials != nullptr
• Mesh / MeshUnmanaged — guards with vboId != nullptr
• Material — guards with maps != nullptr
• Sound — guards with frameCount != 0
• AudioStream — guards with IsAudioStreamValid()
• AutomationEventList — guards with events != nullptr
• Wave — allows value-copy via Copy() (intentional), guards with data != nullptr

---

Issues found ❌

1. RenderTexture::Unload() — no validity guard

// include/RenderTexture.hpp:86
void Unload() { UnloadRenderTexture(*this); }  // unconditional

IsValid() already exists on this class. Fix:

void Unload() {
    if (IsValid()) {
        ::UnloadRenderTexture(*this);
        id = 0;
    }
}

Also, operator=(const ::RenderTexture&) at line 62 sets without calling Unload() first, leaking any existing framebuffer.

---

2. Music::Unload() — no validity guard

// include/Music.hpp:90
void Unload() { ::UnloadMusicStream(*this); }  // unconditional

IsValid() already exists (IsMusicValid). Fix:

void Unload() {
    if (IsValid()) {
        ::UnloadMusicStream(*this);
        ctxData = nullptr;
        ctxType = 0;
    }
}

Also, operator=(const ::Music&) at line 63 sets without calling Unload() first, leaking any existing stream.

---

3. ModelAnimation::Unload() — no validity guard

// include/ModelAnimation.hpp:75-77
void Unload() {
    ::UnloadModelAnimations(this, 1);  // unconditional
}

A moved-from or default-constructed ModelAnimation (with keyframePoses == nullptr) will still call into raylib. Fix:

void Unload() {
    if (keyframePoses != nullptr) {
        ::UnloadModelAnimations(this, 1);
        keyframePoses = nullptr;
    }
}

---

4. VrStereoConfig — no copy/move semantics defined

// include/VrStereoConfig.hpp
class VrStereoConfig : public ::VrStereoConfig {
public:
    VrStereoConfig(const ::VrDeviceInfo& info) { Load(info); }
    ~VrStereoConfig() { Unload(); }
    void Unload() { ::UnloadVrStereoConfig(*this); }
    // No copy/move constructors or assignment operators defined
};

Because ::VrStereoConfig is all-value (no heap pointers), double-unload is low risk, but the class should still follow the same pattern as the others for consistency and correctness:

VrStereoConfig(const VrStereoConfig&) = delete;
VrStereoConfig& operator=(const VrStereoConfig&) = delete;
VrStereoConfig(VrStereoConfig&&) = default;
VrStereoConfig& operator=(VrStereoConfig&&) = default;

---

5. Window and AudioDevice — copy not deleted

Both classes manage singleton-like global state and lack deleted copy constructors/assignment. While their destructors are safe (guarded by IsWindowReady() / CloseAudioDevice() being idempotent), copying them is semantically wrong and could trigger double-close in edge cases:

// Should add to both:
Window(const Window&) = delete;
Window& operator=(const Window&) = delete;

AudioDevice(const AudioDevice&) = delete;
AudioDevice& operator=(const AudioDevice&) = delete;

---

Summary

Class	Copy deleted	Move ok	Unload guarded
Texture	✅	✅	✅
RenderTexture	✅	✅	❌
Shader	✅	✅	✅
Font	✅	✅	✅
Model	✅	✅	✅
Mesh	✅	✅	✅
Material	✅	✅	✅
Sound	✅	✅	✅
Music	✅	✅	❌
AudioStream	✅	✅	✅
Wave	(copies via Copy())	✅	✅
ModelAnimation	✅	✅	❌
VrStereoConfig	❌	❌	(low risk)
AutomationEventList	✅	✅	✅
Window	❌	—	✅ (static)
AudioDevice	❌	—	✅ (idempotent)