fever authorization stopped working after 9.9 update

[SoiledBrush]

• OS: [Android 13]
• APP: [0.9.9]

My miniflux account connected through fever stopped syncing with error "Unauthorized".

And adding the same account as new one gets me error "Not valid credentials".

[Ashinch]

Does it work in version 0.9.8?

[SoiledBrush]

Yes, it does

[mbestavros]

Confirmed, I'm seeing the same issue with my saved Fever credentials. I'm testing out reverting some commits that may have introduced the bug over at #508; will report back with any results.

[mbestavros]

@Ashinch I have some good news, and some bad news. Good news: I found the culprit! Bad news: it's the giant refactoring you did in September 😭

More specifically, it appears to be this commit: 8f1966d

Reverting all code commits that rely on that commit (including favicon support, unfortunately) does fix it, but this seems drastic. If you're able to dig into it and figure out what's going wrong, that would be ideal, but in the meantime we should decide what to do with the release.

(My apologies for backing us into a corner by releasing 0.9.9. I'll definitely test more thoroughly next time before cutting a release...)

[zhusuner]

@Ashinch I have some good news, and some bad news. Good news: I found the culprit! Bad news: it's the giant refactoring you did in September 😭

More specifically, it appears to be this commit: 8f1966d

Reverting all code commits that rely on that commit (including favicon support, unfortunately) does fix it, but this seems drastic. If you're able to dig into it and figure out what's going wrong, that would be ideal, but in the meantime we should decide what to do with the release.

(My apologies for backing us into a corner by releasing 0.9.9. I'll definitely test more thoroughly next time before cutting a release...)

Don't beat yourself up. Let's take the test together. It will both reduce your stress and make the test more fulfilling. Let's make ReadYou better.

[mbestavros]

@Ashinch This keeps getting weirder...

When I test a debug build using Android Studio, everything works fine. But when I run a release build of the same commit, I get the bug...

It's late where I am, and I have to get to bed. But I'm baffled.

[kid1412621]

@Ashinch This keeps getting weirder...

When I test a debug build using Android Studio, everything works fine. But when I run a release build of the same commit, I get the bug...

It's late where I am, and I have to get to bed. But I'm baffled.

I got into the same situation, So I doubt it's introduced by the refactor since it was basically renaming. Anyway, sleep tight.

[mbestavros]

Okay, final action of the night: just marked 0.9.9 as a pre-release. I don't want this bug being pushed out to stable users if we can help it.

@Ashinch Should we go further and take the release down entirely?

[Ashinch]

More specifically, it appears to be this commit: 8f1966d

@mbestavros

I'll investigate, no need to revert more commit.

[Ashinch]

@Ashinch Should we go further and take the release down entirely?

No, I'll fix it as soon as I can.

[mbestavros]

@Ashinch To clarify, I haven't pushed any reversions to the main branch yet; only on my fork.

No, I'll fix it as soon as I can.

Awesome! If you manage to fix it up, I can help push out a 0.9.10 release with the fix, if needed.