Skip to content

fix(sdk): validate dry-run affordability - #3121

Closed
UnArbosFive wants to merge 1 commit into
release-v450from
fix/root-dry-run-affordability
Closed

fix(sdk): validate dry-run affordability#3121
UnArbosFive wants to merge 1 commit into
release-v450from
fix/root-dry-run-affordability

Conversation

@UnArbosFive

Copy link
Copy Markdown
Contributor

Summary

  • resolve dynamic root-registration burn once during preflight and expose it as planned spend
  • reject unaffordable bounded dry-runs before signing, including fee, frozen-balance, existential-deposit, proxy, multisig, and ordered-batch requirements
  • enforce spend policies against the chain-resolved amount

Validation

  • Ruff lint and format checks
  • focused dry-run, CLI, intent-table, and multisig tests: 622 passed
  • full Python unit suite: 1,792 passed, 1 skipped
  • live testnet root-register dry-run: reported 1 TAO spend plus fee and existential-deposit shortfall, returned ok false, and did not submit

@vercel

vercel Bot commented Aug 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
subtensor Ready Ready Preview Aug 27, 2026 5:16pm

Request Review

@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

🛡️ AI Review — Skeptic (security review)

VERDICT: SAFE

VERY HIGH scrutiny due to a 56-day-old account with no public repositories, moderated by admin permission and substantial merged subtensor contributions; no Gittensor association found. Branch: fix/root-dry-run-affordability → release-v450.

Static analysis covered all 14 changed files. The PR changes only Python SDK affordability planning and tests; it does not modify dependencies, runtime code, CI configuration, or the AI-review trust boundary.

Findings

No findings.

Conclusion

No malicious behavior or security vulnerability was found. The new bounded-spend checks fail closed when fee, account, or proxy fee-payer state cannot be verified.


🔍 AI Review — Auditor (domain review)

VERDICT: 👍

Gittensor association: UNKNOWN; established, high-volume contributor with repository admin permission.

The change consistently uses the chain-resolved root-registration burn for display, spend-policy enforcement, and affordability checks. Direct, proxy, multisig, frozen-balance, existential-deposit, ordered-batch, and failure-path behavior have focused coverage.

No substantive duplicate was found among the mechanically overlapping PRs.

Python Ruff checks were skipped because the existing environment lacks uv. git diff --check passed and the worktree is clean. Runtime tests were not rerun because static review found no issue requiring confirmation.

Findings

No findings.

Conclusion

The implementation matches the PR description, preserves execution-account distinctions, and includes strong boundary coverage. No blocking domain issues found.

@github-actions

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

@UnArbosFour
UnArbosFour deleted the branch release-v450 August 27, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants