list/tuple: rename slice -> get_slice - #1828
Merged
Merged
Conversation
davidhewitt
requested changes
Aug 24, 2021
davidhewitt
left a comment
davidhewitt
left a comment
Member
There was a problem hiding this comment.
👍 I 100% agree with doing this!
Can you please re-add .slice() as a deprecated API for one release cycle? It makes it easier for users to upgrade their code.
Member
Author
|
So, should the deprecated method continue to use |
Member
|
Oooh good question! I think the original |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only tuple's method is renamed; list's method is a new API in 0.15.