Dockerize discoreg - #4
Conversation
| ENV PYTHONUNBUFFERED 1 | ||
|
|
||
| WORKDIR /discoreg | ||
| EXPOSE 80 |
There was a problem hiding this comment.
We'll be running this behind nginx, so can we use 8000 (or whatever gunicorn's default port is) here?
There was a problem hiding this comment.
Can we use something like pip-compile to retain the separation of top-level and fully pinned requirements? Happy to contribute this change to the PR myself, just want to make sure we don't lose that information and the ability to reasonably upgrade dependencies going forward.
There was a problem hiding this comment.
We should probably make the database configurable (e.g. with https://github.com/jazzband/dj-database-url) along with this change. In the mean time, I'll likely mount the path to the database as a docker volume to make sure it persists to disk.
2 participants
First shot at dockerizing discoreg
2 containers can be created