Trim fastmcp.types to FastMCP-unique types - #4584
Merged
Merged
Conversation
fastmcp.types re-exported 29 mcp_types symbols verbatim, which was pointless indirection users had to discover. It now holds only Textarea, the one type FastMCP actually defines; everything else imports from mcp_types directly. These mirrors were added during unreleased SDK v2 migration work and never shipped, so this is not a breaking change.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e32a2098f9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
3 tasks
marvin-context-protocol
Bot
added
the
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fastmcp.typeshad drifted into a near-total mirror ofmcp_types— about 29 barefrom mcp_types import X as Xre-exports (Completion,ContentBlock,CallToolResult,PromptMessage, and so on). That is pointless indirection: code importing an MCP protocol type should import it frommcp_types, not through a FastMCP alias that adds nothing.This trims
fastmcp.typesto the one type FastMCP genuinely defines —Textarea— and repoints every internal call site, example, and docs code block atmcp_typesdirectly.fastmcp.typesnow means "types that are FastMCP's own," which is what a reader expects it to mean.This is not a breaking change. At the last release (v3.4.4)
fastmcp.types.__all__was exactly["Textarea"]; every mirror was added later in unreleased work, so no released import breaks.Label: enhancements