-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Drop forked client protocol helpers in favor of the SDK's #4574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3775c06
Delegate forked client protocol helpers to the SDK
jlowin fa284cc
Merge client-auto-default; keep SDK _synthesize_discover with the new…
jlowin be7c157
Drop duplicate local helpers reintroduced by the merge; use SDK versions
jlowin 052b117
Merge remote-tracking branch 'origin/main' into feature/client-compos…
jlowin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These imports are rebound by the module-level
_fold_extensionsand_evicting_message_handlerdefinitions at lines 226 and 295, so all call sites still use FastMCP's forked copies. In particular,Client(extensions=[...])continues through the local folding function, which never callsvalidate_extension_identifier, and therefore still accepts identifiers such as"foo"despite this change's intended validation tightening; remove the local helper definitions (and_FoldedExtensions) so the SDK implementations are actually used.Useful? React with 👍 / 👎.