Make transformed tool required order deterministic - #4564
Merged
strawgate merged 1 commit intoJul 20, 2026
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4565
Snapshot-testing
tools/listoutput was impossible for servers using transformed tools: the JSON changed between test runs. The cause is thatTransformedToolbuilt itsrequiredarray withlist(set), so the order depended on Python's per-process hash randomization (PYTHONHASHSEED) — every fresh interpreter could produce a different ordering of the same schema.This PR makes
requiredfollow the schema's property order in both_create_forwarding_transformand_merge_schema_with_precedence, so the wire format is stable across processes (and easier to read). Verified by hashingtools/listJSON under severalPYTHONHASHSEEDvalues: previously every seed produced a different result; now they're identical.Label: bugs
🤖 Generated with GitHub Copilot CLI