[codex] Fix event store replay isolation - #4402
Merged
Merged
Conversation
jlowin
marked this pull request as ready for review
June 27, 2026 16:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streamable HTTP resumability stored events in one shared backend keyed only by the SDK stream id. Those ids are scoped to an SDK transport rather than globally unique, so separate client sessions could share
_GET_streamor the same request id and allow reconnect replay to cross a session boundary.This PR adds a session-scoped EventStore adapter and gives each Streamable HTTP transport its own adapter while preserving the shared storage backend. Replay now buffers events until it verifies that the resolved stream id belongs to the current session scope, then returns the original SDK stream id so transport behavior remains unchanged.
With overlapping stream ids,
session_a.replay_events_after(...)now emits only events stored throughsession_a.