Node deletions - #2756
Draft
ljeub-pometry wants to merge 4 commits into
Draft
Conversation
…t for adding node deletions
…e some redundant trait layers
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: a002416 | Previous: 9823ef7 | Ratio |
|---|---|---|---|
lotr_graph/num_edges |
4 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph/num_nodes |
4 ns/iter (± 0) |
1 ns/iter (± 0) |
4 |
lotr_graph/graph_latest |
2 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph_materialise/materialize |
6665837 ns/iter (± 35902) |
1564816 ns/iter (± 35303) |
4.26 |
lotr_graph_window_100/num_nodes |
11 ns/iter (± 0) |
5 ns/iter (± 0) |
2.20 |
lotr_graph_window_100_materialise/materialize |
6631929 ns/iter (± 23301) |
1669150 ns/iter (± 10700) |
3.97 |
lotr_graph_window_10/has_node_existing |
157 ns/iter (± 7) |
62 ns/iter (± 11) |
2.53 |
lotr_graph_window_10_materialise/materialize |
2791552 ns/iter (± 13502) |
971980 ns/iter (± 4278) |
2.87 |
lotr_graph_subgraph_10pc/num_nodes |
15 ns/iter (± 0) |
4 ns/iter (± 0) |
3.75 |
lotr_graph_subgraph_10pc_materialise/materialize |
1839989 ns/iter (± 11600) |
334634 ns/iter (± 1287) |
5.50 |
lotr_graph_subgraph_10pc_windowed/has_node_existing |
158 ns/iter (± 7) |
62 ns/iter (± 14) |
2.55 |
lotr_graph_subgraph_10pc_windowed_materialise/materialize |
1075760 ns/iter (± 12726) |
230399 ns/iter (± 2617) |
4.67 |
lotr_graph_window_50_layered/has_node_existing |
402 ns/iter (± 14) |
129 ns/iter (± 12) |
3.12 |
lotr_graph_window_50_layered/graph_latest |
79903 ns/iter (± 2319) |
36649 ns/iter (± 916) |
2.18 |
lotr_graph_window_50_layered_materialise/materialize |
24439185 ns/iter (± 128169) |
3488825 ns/iter (± 24948) |
7.00 |
lotr_graph_persistent_window_50_layered/num_edges_temporal |
437690 ns/iter (± 9840) |
192686 ns/iter (± 1569) |
2.27 |
lotr_graph_persistent_window_50_layered/graph_latest |
132082 ns/iter (± 12627) |
57549 ns/iter (± 4809) |
2.30 |
lotr_graph_persistent_window_50_layered_materialise/materialize |
40006670 ns/iter (± 107236) |
5298035 ns/iter (± 147912) |
7.55 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Fixes #1724
Does this PR introduce any user-facing change? If yes is this documented?
How was this patch tested?
Are there any further changes required?