Fix deadlock - #2292
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'GraphQL Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 00ea467 | Previous: db0c971 | Ratio |
|---|---|---|---|
addNode |
0 req/s |
1404 req/s |
+∞ |
This comment was automatically generated by workflow using github-action-benchmark.
This was referenced Oct 1, 2025
miratepuffin
added a commit
that referenced
this pull request
Oct 10, 2025
* Fix deadlock (#2292) * make a write pool * use blocking_write for all graph mutations * enable tests * chore: apply tidy-public auto-fixes * fix the recursive read deadlock * chore: apply tidy-public auto-fixes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Release v0.16.2 (#2299) chore: Release Co-authored-by: Pometry-Team <ben.steer@pometry.com> * Deadlock fixes and concurrency configuration (#2313) * make all the rw_lock.read be read_recursive * fixes deadlocks * fixes Python deadlock * add a sempahore in front of the graphql query execution * sort pr and add env variable to be able to set concurrency limit * add rwlock in the middleware * loop when taking the PairEntryMut lock * make rwlock optional * chore: apply tidy-public auto-fixes * rename env var for concurrency limit --------- Co-authored-by: Fabian Murariu <murariu.fabian@gmail.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore: apply tidy-public auto-fixes --------- Co-authored-by: ljeub-pometry <97447091+ljeub-pometry@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Pometry-Team <ben.steer@pometry.com> Co-authored-by: Pedro Rico Pinazo <ricopinazo@gmail.com> Co-authored-by: Fabian Murariu <murariu.fabian@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Deadlocks observed in the server
Does this PR introduce any user-facing change? If yes is this documented?
no
How was this patch tested?
tests
Are there any further changes required?