Skip to content

Improve ENR equality logic - #116

Merged
uink45 merged 4 commits into
mainfrom
enr-equality
Jan 6, 2026
Merged

Improve ENR equality logic#116
uink45 merged 4 commits into
mainfrom
enr-equality

Conversation

@flcl42

@flcl42 flcl42 commented Jan 2, 2026

Copy link
Copy Markdown
Collaborator

@flcl42
flcl42 force-pushed the enr-equality branch 4 times, most recently from e92b8a3 to 64051ef Compare January 2, 2026 12:35
@flcl42
flcl42 marked this pull request as ready for review January 5, 2026 15:42
@flcl42
flcl42 requested a review from uink45 January 5, 2026 15:43
@uink45

uink45 commented Jan 6, 2026

Copy link
Copy Markdown
Collaborator

Hi @flcl42, confirming the changes are looking good. Will accept merge this PR.

@uink45
uink45 merged commit e2ce14a into main Jan 6, 2026
2 of 4 checks passed
@flcl42

flcl42 commented Jan 6, 2026

Copy link
Copy Markdown
Collaborator Author

Hi @flcl42, confirming the changes are looking good. Will accept merge this PR.

Thanks! Unable to publish it though, sonar cube steps fail. Mind if I comment out them, or maybe there is a different solution?

May be related to https://github.com/Pier-Two/Lantern.Discv5/actions/runs/20741543523/job/59549247294#step:8:19

WARNING: Authentication with the server has failed.

@uink45

uink45 commented Jan 6, 2026

Copy link
Copy Markdown
Collaborator

Hi @flcl42, confirming the changes are looking good. Will accept merge this PR.

Thanks! Unable to publish it though, sonar cube steps fail. Mind if I comment out them, or maybe there is a different solution?

May be related to https://github.com/Pier-Two/Lantern.Discv5/actions/runs/20741543523/job/59549247294#step:8:19

WARNING: Authentication with the server has failed.

Right, yeah that can be commented out for now. We will integrate a different solution in the future for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants