Skip to content

chore(git): ignore local benchmark artifacts #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PatrickSys merged 2 commits into from
Apr 29, 2026
Merged

chore(git): ignore local benchmark artifacts #118

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a2a66b
chore(git): ignore local benchmark artifacts
PatrickSys Apr 29, 2026
ef42e53
fix(git): scope local artifact ignores
PatrickSys Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,26 @@ grammars/*.wasm
docs/visuals.md
.repolore/
.opencode/
.agents/
CODEBASE_MAP.md
repos/

# Local benchmark/lab outputs
benchmark-runs/
outputs/

@greptile-apps greptile-apps Bot Apr 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 outputs/ is a very broad top-level ignore

Ignoring outputs/ at the repository root will silently suppress any directory by that name, including legitimate build artifacts or test outputs that a future contributor might intend to track. If only the benchmark-related outputs/ is meant, consider scoping it (e.g. benchmark-runs/outputs/ or a comment-aligned path).

@PatrickSys PatrickSys Apr 29, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in the current diff: outputs/ is now root-anchored as /outputs/, so it only ignores the repo-root generated outputs directory instead of any nested directory named outputs.

results/skeptical-user/raw/
results/skeptical-user/local/
results/skeptical-user/tmp/
.tmp-skeptical-user/

@greptile-apps greptile-apps Bot Apr 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 User-specific paths belong in a global gitignore

results/skeptical-user/, .tmp-skeptical-user/ encode a specific username. Shared .gitignore entries like these add noise for other contributors and are better placed in each developer's ~/.gitignore_global (or git config --global core.excludesFile). The same applies to any path that only makes sense on one person's machine.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@PatrickSys PatrickSys Apr 29, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed for the results paths: the specific
esults/skeptical-user/... entries were replaced with generalized /results/*/{raw,local,tmp}/ patterns. .tmp-skeptical-user/ is a benchmark-suite temp directory rather than a developer username, and it stays ignored because it is a local generated lab artifact.


# External benchmark/research clones
matplotlib-repo/
sympy-contextbench/

# Local agent/vendor artifacts
**/skills/bmad-*/
_bmad/
_bmad-*/
_bmad-output/

# Local browser automation artifacts
.playwright-mcp/
Loading