Fix Absolution/Dominating Blow of Inspiring FullDPS when using config - #8945
Merged
Conversation
The option to show only 1x the players hit DPS was not working for the alternate versions of the skill cause we were looking for a exact match on the name Also realised that the config option was not even showing up for Dominating Blow of inspiring so fixed that too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The option to show only 1x the players hit DPS was not working for the alternate versions of the skill cause we were looking for a exact match on the name
Also realised that the config option was not even showing up for Dominating Blow of inspiring so fixed that too
Fixes #8927