Fix Elemental Overload applying to skills with 0 Crit Chance - #8772
Merged
Conversation
The elemental flag for "CritInPast8s" was only false when the "NeverCrit" flag was true instead of checking to see if the skill has any crit chance
LocalIdentity
pushed a commit
to PathOfBuildingCommunity/PathOfBuilding-PoE2
that referenced
this pull request
Aug 29, 2025
LocalIdentity
added a commit
to PathOfBuildingCommunity/PathOfBuilding-PoE2
that referenced
this pull request
Aug 29, 2025
PathOfBuildingCommunity/PathOfBuilding#8862 PathOfBuildingCommunity/PathOfBuilding#8772 PathOfBuildingCommunity/PathOfBuilding#8754 PathOfBuildingCommunity/PathOfBuilding#8739 Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Tonkat
pushed a commit
to Tonkat/PathOfBuilding-PoE2
that referenced
this pull request
Sep 1, 2025
PathOfBuildingCommunity/PathOfBuilding#8862 PathOfBuildingCommunity/PathOfBuilding#8772 PathOfBuildingCommunity/PathOfBuilding#8754 PathOfBuildingCommunity/PathOfBuilding#8739 Co-authored-by: LocalIdentity <localidentity2@gmail.com>
bct8925
pushed a commit
to bct8925/PathOfBuilding-PoE2
that referenced
this pull request
Jun 19, 2026
PathOfBuildingCommunity/PathOfBuilding#8862 PathOfBuildingCommunity/PathOfBuilding#8772 PathOfBuildingCommunity/PathOfBuilding#8754 PathOfBuildingCommunity/PathOfBuilding#8739 Co-authored-by: LocalIdentity <localidentity2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8770, Fixes #4429, Fixes #5494
The elemental flag for "CritInPast8s" was only false when the "NeverCrit" flag was true instead of checking to see if the skill has any crit chance