Buy similar: fix mod matching and improve search workflow#1942
Open
vaisest wants to merge 42 commits into
Open
Buy similar: fix mod matching and improve search workflow#1942vaisest wants to merge 42 commits into
vaisest wants to merge 42 commits into
Conversation
…currency rates
…ate limiting waits if possible
…lems, and to show it on non-429 rate limit. (429 issue solved on GGG's side)
…earch tries to add results to controls
…shes in a similar format as previous mod export changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
This ports PathOfBuildingCommunity/PathOfBuilding#9857 and fixes any remaining mod mismatches. As far as I can see, every mod matches correctly now.
Steps taken to verify a working solution:
Be careful when testing with poe.ninja profiles. There was a bug that causes enchants to be exported as implicits. This breaks the mod matching here due to the trade site matching affixes by implicit and enchant separately. This has since been fixed, but since the league is dead, most profiles haven't been refreshed.
Link to a build that showcases this PR:
A bunch of random builds:
See linked PR for screenshots.
Depends on #1801