Fix example does not compile - #2
Conversation
Hey @ttytm 👋 , Thanks for the PR, I did notice that the example code is a little outdated and has a few issues, but I am currently working on a massive improvement to the library which will change the way it is currently being used. It will be much easier as well as give more options to the end user. Here is a quick breakdown of the changes: Checkable menu items. These are just some of the new features. I will ask that you please put my PR on hold for the webview until the rework is done If you are curios of the code, there is another branch "optimization" that you can browse through. |
|
Okay, sounds and looks good 🙂. When the optimizations are finished and the suggestion I thought of is still applicable I can submit it then. For now I won't interfere 👍 |
Hey @Ouri028 👋, currently the example does not compile.
I'd like to make a suggestion that I think can be a good improvement for the lib in a separate PR, to then also finish the example PR for webview you submitted.
I think if we the simple example is fixed first, it can be easier to have it as something concrete to work with in the proposal I am thinking about.