Several public identifiers misname their cryptographic role: spending_key holds a public key; spendable_balance/receiving_balance are Pedersen commitments; five auditor ciphertext fields drop the _tilde marker their circuit publics carry; encrypted_allowance uses a third marker style; the r_e event field carries the point R_e, not the scalar; op_i is a domain separator that reads as a loop index.
Planned fix: rename to spending_public_key, spendable_commitment/receiving_commitment, *_tilde_aud_* (matching circuit publics), a_tilde, spender_id; decide r_e and tx→tfer case-by-case. Payload/event field renames change the XDR encoding — coordinate with prover tooling.
Files: packages/tokens/src/confidential/{storage,mod}.rs, circuits, DESIGN docs
Several public identifiers misname their cryptographic role:
spending_keyholds a public key;spendable_balance/receiving_balanceare Pedersen commitments; five auditor ciphertext fields drop the_tildemarker their circuit publics carry;encrypted_allowanceuses a third marker style; ther_eevent field carries the pointR_e, not the scalar;op_iis a domain separator that reads as a loop index.Planned fix: rename to
spending_public_key,spendable_commitment/receiving_commitment,*_tilde_aud_*(matching circuit publics),a_tilde,spender_id; decider_eandtx→tfercase-by-case. Payload/event field renames change the XDR encoding — coordinate with prover tooling.Files:
packages/tokens/src/confidential/{storage,mod}.rs, circuits, DESIGN docs