Lower listings

[jerone]

What do you guys think about lowering the listing items?

Possible pro's:

• More items visible.
• Removes white space.

Possible cons:

• Different item heights when multi-line descriptions.

For example: https://openuserjs.org/group/Github

[Martii]

Font size or clipping the description text? I think I'm missing what you mean by lowering.

[Martii]

ahhh perceived line spacing and padding I think?

[jerone]

Actually the progress bar has a margin-bottom: 20px; which makes all items in the listing the same size.

[Martii]

I have nothing against it but check for too small of size entries for portable devices on smaller cells e.g. no @description and minimal @name... someone with "big fingers" or accessibility needs may need a larger format. Would also be useful to show a (drastic) "screenie" multiline effect it has with this proposal if you are up to it.

[jerone]

I tested on multiple browsers on the iPad, Android tablet and two Android phones (and tested in Chrome Developer Tools device mode). All handle the smaller listing without problems. I also tested scripts without and with multiple lines @description. The listing items are still big enough to press.

I would also suggest vertical aligning all listing items.

I'll send a PR soon so others can test it and see if they like it too.

[jerone]

I'll send a PR soon so others can test it and see if they like it too.

I just pushed a commit to another branch so others can test this change before I send a PR.

With that change I also pushed a commit that changes all items in the listings to align vertically.

As I said above, this is tested working on different configurations (down to IE 9). I'm not sending a PR just yet, first to get your opinions about these design changes.
cc @Martii @Zren @sizzlemctwizzle

[Martii]

I'm not real fond of the vertical align in c3677eb but 4481c19 seems reasonable to tighten up the white to black space to be a little more congruent with other existing panels... it does however need some more feedback though... especially @Zren since he's currently into bootstrap the most.

Sizzle could be modifying the vote portion a bit too but having the slopes seems a bit distracting for speed reading/skimming as depicted below with the mouse cursor:

[Zren]

Just remove the bar underneath the rating as it's currently not very useful since the percentages aren't calculated correctly anyways.

Edit: Don't remove the code in the controller though, as that could be useful when I get the chance to fix Script moderation and Script "actions".

[Martii]

Just remove the bar underneath the rating as it's currently not very useful since the percentages aren't calculated correctly anyways.

It is useful to administration and considering I'm the one that corrected it in #288 from your implementation I think it is working well... you could have said something more back then and you could be a little more specific now as to your claim that it's not calculated correctly. e.g. I would prefer the bar not to be removed... anyway that's locked by #262 with sizzle... so it's not currently an option anyhow.

[Zren]

It's suppose to be an up/downvote percentage bar, except we don't keep a proper count of upvotes/downvotes in the Script model. The flagged value was used since I didn't want to throw out my work on the rating bar since I expected to rewrite that bit once I started editing the models. I later found out my assumptions of what votes represented was off (I thought it was the count not the sum), which caused the bugs you thought you fixed.

https://github.com/OpenUserJs/OpenUserJS.org/blob/master/controllers/script.js#L474

• Script.votes is really the rating as it's the sum() of all the up(+1)/downvotes(-1).
• Script.rating is completely broken as Script Authors and above increment it by 2 instead of 1. Meaning you can vote as a regular user, upload a script, then unvote, and have it off by 1 of where it should be.

locked by #262 with sizzle

If he doesn't have any work done on it by the time pushdescription is done, then he's out of luck. It's been months now with no progress. He hasn't even pushed his in-progress to a new branch to show what he's done. If he did so, then others could even cherry pick what he's done and merge the working parts for him.

[Martii]

If he doesn't have any work done on it by the time pushdescription is done, then he's out of luck.

I would like you to reread the TOS specifically here (pay attention to currently the last bullet)... which this statement violates... e.g. you will not be demanding anything from anyone... this is a large portion of why you were demoted and are recommended currently to continue to be demoted. He will contribute publicly to his owned project when he is ready. If you can't deal with it he will and I'll support whatever he decides along with my 2 cents.

It's suppose to be an up/downvote percentage bar, except we don't keep a proper count of upvotes/downvotes in the Script model.

"Supposed to be" versus "what it is" are two different things. You haven't been doing any moderation on the OUJS site either so you sometimes skip administration considerations.

[jerone]

Please keep things ontopic and great another issue or move it to Gitter.