Skip to content

feat: add order invoice component #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomrndom wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: add order invoice component #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bbb8578
feat: add order invoice component
tomrndom Jul 3, 2026
a9a7e61
fix: adjust tests, fix bugs, change names
tomrndom Jul 3, 2026
1aeffdb
fix: clear unused import, add catch for missing date
tomrndom Jul 3, 2026
11f83a9
fix: split file for better readability, adjust test and functions
tomrndom Jul 7, 2026
c09b291
fix: adjust export on component index file
tomrndom Jul 7, 2026
3117fa8
fix: throw error if order or summit is missing
tomrndom Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"@mui/icons-material": "^6.4.3",
"@mui/material": "^6.4.3",
"@mui/x-date-pickers": "^7.26.0",
"@react-pdf/renderer": "^3.1.11",
"@react-pdf/renderer": "^4.4.1",

@smarcet smarcet Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomrndom @react-pdf/renderer is bumped from ^3.1.11 to ^4.4.1 here (and at line 129, peerDependencies), but yarn.lock wasn't updated — it still resolves 3.1.12. This is a major, breaking upstream release (v4.0.0 dropped CJS support per the official changelog), and it's a peer dependency already used by schedule-print-button.js/schedule-print-view.js, which have no test coverage. Since this PR's own test suite fully mocks @react-pdf/renderer, the v3→v4 upgrade is currently unverified anywhere in the repo. Could we regenerate the lockfile and do a manual smoke test of schedule-print (and this new component) rendering under v4 before merging?

"@sentry/react": "^8.54.0",
"@sentry/webpack-plugin": "^3.1.2",
"@stripe/react-stripe-js": "^5.4.1",
Expand Down Expand Up @@ -126,7 +126,7 @@
"@mui/icons-material": "^6.4.3",
"@mui/material": "^6.4.3",
"@mui/x-date-pickers": "^7.26.0",
"@react-pdf/renderer": "^3.1.11",
"@react-pdf/renderer": "^4.4.1",
"@sentry/react": "^8.54.0",
"@stripe/react-stripe-js": "^5.4.1",
"@stripe/stripe-js": "^8.5.3",
Expand Down
1 change: 1 addition & 0 deletions src/components/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,3 +139,4 @@ export {MuiBaseCustomTheme} from './mui/MuiBaseCustomTheme'
// export {default as MuiAdditionalInput} from './mui/formik-inputs/additional-input/additional-input' // react-beautiful-dnd (via dnd-list)
// export {default as MuiAdditionalInputList} from './mui/formik-inputs/additional-input/additional-input-list' // react-beautiful-dnd (via dnd-list)
// export {default as MuiDragNDropList} from './mui/DragNDropList' // @dnd-kit/core @dnd-kit/sortable @dnd-kit/utilities
// export {OrderPdf, buildRows as buildOrderPdfRows, generateInvoicePDF, previewPDF} from './order-invoice-pdf' // @react-pdf/renderer
Loading
Loading