Skip to content

Make project home configurable #689 - #748

Merged
FlorianK13 merged 2 commits into
developfrom
689-refactor-project-home-setup
May 22, 2026
Merged

Make project home configurable #689#748
FlorianK13 merged 2 commits into
developfrom
689-refactor-project-home-setup

Conversation

@FlorianK13

Copy link
Copy Markdown
Member
  • Remove get_data_version_dir() - This function is redundant as its logic can be inlined where it's used (e.g., in mastr.py:438 as os.path.join(self.output_dir, "data", get_data_config()))
  • Add MASTR_PROJECT_HOME_DIR environment variable support to get_project_home_dir() - Currently only OUTPUT_PATH is respected, but users need to be able to override the base project home directory itself (where credentials and config are stored), not just the output path - this is relevant for setting up a project home for testing

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

Also remove on unnecessary config function
@FlorianK13 FlorianK13 linked an issue May 22, 2026 that may be closed by this pull request
@FlorianK13
FlorianK13 marked this pull request as ready for review May 22, 2026 08:17
@FlorianK13
FlorianK13 requested a review from kvnkrmr May 22, 2026 08:18
@FlorianK13 FlorianK13 mentioned this pull request May 22, 2026
5 tasks
@FlorianK13

Copy link
Copy Markdown
Member Author

Sure tests fail, but that is why we have #749

@FlorianK13
FlorianK13 merged commit e764187 into develop May 22, 2026
0 of 9 checks passed
@FlorianK13
FlorianK13 deleted the 689-refactor-project-home-setup branch May 22, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logger does not use the defined directory

2 participants