Skip to content

Add warning message if the bulk download speed falls below a certain … - #262

Merged
FlorianK13 merged 2 commits into
developfrom
feature-256-download-limitation
Jun 7, 2022
Merged

Add warning message if the bulk download speed falls below a certain …#262
FlorianK13 merged 2 commits into
developfrom
feature-256-download-limitation

Conversation

@deniztepe

Copy link
Copy Markdown
Contributor

…limit #256

  • The limit is set to 100kB/s
  • The unit of tqdm bar is set to MB, since each iteration corresponds to one megabyte

closes #256

…limit #256

* The limit is set to 100kB/s
* The unit of tqdm bar is set to MB, since each iteration corresponds to one megabyte
@deniztepe
deniztepe requested a review from FlorianK13 June 3, 2022 11:21
@deniztepe deniztepe self-assigned this Jun 3, 2022
@deniztepe

Copy link
Copy Markdown
Contributor Author

The warning message should work fine now. Testing it is not intuitive, because you have to limit the download speed manually. Instead you can set the warning limit higher to something like 12 MB/s in open_mastr/xml_download/utils_download_bulk.py:58 and run the following script:

from open_mastr.xml_download.utils_download_bulk import download_xml_Mastr
import os

# xml download
save_path = os.path.join(
            os.path.expanduser("~"), ".open-MaStR", "data", "Gesamtexport_test"
        )
download_xml_Mastr(save_path=save_path)

@deniztepe deniztepe linked an issue Jun 3, 2022 that may be closed by this pull request

@FlorianK13 FlorianK13 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a small spelling mistake.

Comment thread open_mastr/xml_download/utils_download_bulk.py Outdated

@FlorianK13 FlorianK13 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@FlorianK13
FlorianK13 merged commit dd7b3f9 into develop Jun 7, 2022
@FlorianK13
FlorianK13 deleted the feature-256-download-limitation branch June 7, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document download limitation from marktstammdatenregister.de

2 participants