Skip to content

Feature 17 suitability assessment - #21

Open
NormanZielke wants to merge 30 commits into
developfrom
feature-17-suitability-assessment
Open

Feature 17 suitability assessment#21
NormanZielke wants to merge 30 commits into
developfrom
feature-17-suitability-assessment

Conversation

@NormanZielke

@NormanZielke NormanZielke commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Summary of the discussion

Based on #17

Type of change (CHANGELOG.md)

Added

  • suitability assessment
  • shortened heat planning
  • propterty has represented heat supply area

Workflow checklist

Automation

Part of # / Closes #

PR-Assignee

  • 🐙 Follow the workflow in CONTRIBUTING.md
  • 📝 Update the CHANGELOG.md
  • 📙 Update the documentation
  • 🐙 Assign a reviewer to the PR

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@stap-m

stap-m commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

@NormanZielke is this PR ready for review? If yes, please assign reviewers (e.g. me :) ).

@NormanZielke

NormanZielke commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator Author

there is just one remaining part, we didn't discussed yet. Belong the property I suggested in #17. is justified by. What do you think about it?

@NormanZielke
NormanZielke requested a review from stap-m August 20, 2026 08:12
@stap-m

stap-m commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

As discussed in the meeting on 2026-08-21 you can add a new object property between verkürzter Wärmeplanung und Gebiet für dezentrale Wärmeversorgung

@NormanZielke

Copy link
Copy Markdown
Collaborator Author

As discussed in the meeting on 2026-08-21 you can add a new object property between verkürzter Wärmeplanung und Gebiet für dezentrale Wärmeversorgung

I'm not sure. Did we said, we don't need the property is justified by ? In this case. PR is rdy to review

Comment thread src/ontology/mhpo-edit.owl Outdated
Comment thread src/ontology/mhpo-edit.owl Outdated
# Object Properties
############################

# Object Property: <https://purl.org/mhpo/ontology/MHPO_00030019> (has represented heat supply area)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Object Property: <https://purl.org/mhpo/ontology/MHPO_00030019> (has represented heat supply area)
# Object Property: <https://purl.org/mhpo/ontology/MHPO_00030019> (represents heat supply area)

Comment thread src/ontology/mhpo-edit.owl Outdated

# Object Property: <https://purl.org/mhpo/ontology/MHPO_00030019> (has represented heat supply area)

AnnotationAssertion(<http://purl.obolibrary.org/obo/IAO_0000115> <https://purl.org/mhpo/ontology/MHPO_00030019> "An is-about-relation between an information content entity of a municipal heat plan and a heat supply area to indicate a heat supply area represented in the municipal heat plan."@en)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
AnnotationAssertion(<http://purl.obolibrary.org/obo/IAO_0000115> <https://purl.org/mhpo/ontology/MHPO_00030019> "An is-about-relation between an information content entity of a municipal heat plan and a heat supply area to indicate a heat supply area represented in the municipal heat plan."@en)
AnnotationAssertion(<http://purl.obolibrary.org/obo/IAO_0000115> <https://purl.org/mhpo/ontology/MHPO_00030019> "An is-about-relation between a municipal heat plan and the heat supply area the heat municipal heat plan refers to."@en)

I tried to simplify the wording without reusing is-about and represent again...
Since it is a specific relation for heat plans and areas we should restrict it. Information content entity is too broad.

Comment thread src/ontology/mhpo-edit.owl Outdated
pull request: https://github.com/OpenEnergyPlatform/municipal-heat-planning-ontology/pull/21")
AnnotationAssertion(<https://www.commoncoreontologies.org/ont00001754> <https://purl.org/mhpo/ontology/MHPO_00030019> "Section 14 of the German Heat Planning Act (WPG)")
SubObjectPropertyOf(<https://purl.org/mhpo/ontology/MHPO_00030019> <https://openenergyplatform.org/ontology/oeo/OEO_00010378>)
ObjectPropertyDomain(<https://purl.org/mhpo/ontology/MHPO_00030019> <http://purl.obolibrary.org/obo/IAO_0000030>)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The domain should be municipal heat plan directly.

NormanZielke and others added 3 commits September 9, 2026 09:46
Co-authored-by: stap-m <38690039+stap-m@users.noreply.github.com>
@NormanZielke
NormanZielke requested a review from stap-m September 9, 2026 08:27
@stap-m stap-m added this to the Milestone v0.1.0 milestone Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants