Skip to content

fix: fix data race around spop Dobinlog #2674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexStocks merged 4 commits into from
May 24, 2024
+6 −2
Merged

fix: fix data race around spop Dobinlog #2674

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1fba3da
fix spop binlog data race
cheniujh May 23, 2024
880cb36
Merge branch 'OpenAtomFoundation:unstable' into fix_data_race_spop_bi…
cheniujh May 23, 2024
0c018e7
adjust format
cheniujh May 23, 2024
a6fbfcc
Merge remote-tracking branch 'origin/fix_data_race_spop_binlog' into …
cheniujh May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions include/pika_set.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,10 @@ class SPopCmd : public Cmd {
: Cmd(name, arity, flag, static_cast<uint32_t>(AclCategory::SET)) {
srem_cmd_ = std::make_shared<SRemCmd>(kCmdNameSRem, -3, kCmdFlagsWrite | kCmdFlagsSet);
}
SPopCmd(const SPopCmd& other)
: Cmd(other), key_(other.key_), members_(other.members_), count_(other.count_), s_(other.s_) {
Comment thread
cheniujh marked this conversation as resolved.
srem_cmd_ = std::make_shared<SRemCmd>(kCmdNameSRem, -3, kCmdFlagsWrite | kCmdFlagsSet);
}
std::vector<std::string> current_key() const override {
std::vector<std::string> res;
res.push_back(key_);
Expand Down