Feature/txn (#1585) - #2124
Merged
Merged
Conversation
* fix: fix select cmd return inconsistent with redis Signed-off-by: Hao Lee <1838249551@qq.com> * refactor:modified lock style while involve db level Signed-off-by: Hao Lee <1838249551@qq.com> * feature:txn basic Signed-off-by: Hao Lee <1838249551@qq.com> * fix:merge upstream Signed-off-by: Hao Lee <1838249551@qq.com> * feature:txn udpate Signed-off-by: Hao Lee <1838249551@qq.com> * feature:add txn for pika(#1446) todo:test txn. Just to verify the feasibility of the program. Signed-off-by: Hao Lee <1838249551@qq.com> * update unwatch cmd Add comments Signed-off-by: Hao Lee <1838249551@qq.com> * clear watched key when connection closed Signed-off-by: Hao Lee <1838249551@qq.com> * merge upstream code Signed-off-by: Hao Lee <1838249551@qq.com> * update Signed-off-by: Hao Lee <1838249551@qq.com> * feature: add txn for pika completely Signed-off-by: Hao Lee <1838249551@qq.com> * add set txn failed for modified watch key Signed-off-by: Hao Lee <1838249551@qq.com> * update:reduce the particle size of the lock in txn Signed-off-by: Hao Lee <1838249551@qq.com> * chore:remove redundant comment Signed-off-by: Hao Lee <1838249551@qq.com> * test:add go ci test for txn Signed-off-by: Hao Lee <1838249551@qq.com> * fix compile error for linux Signed-off-by: Hao Lee <1838249551@qq.com> * update txn go ci test Signed-off-by: Hao Lee <1838249551@qq.com> * update txn for block list pop command Signed-off-by: Hao Lee <1838249551@qq.com> * Improve blpop-related in Redis transactions Signed-off-by: Hao Lee <1838249551@qq.com> * blpop_txn_fix * add some test for go test txn Signed-off-by: Hao Lee <1838249551@qq.com> * update txn integration test Signed-off-by: Hao Lee <1838249551@qq.com> * txn change class to struct Signed-off-by: Hao Lee <1838249551@qq.com> * txn:use weak ptr instead of shared ptr in Cmd Signed-off-by: Hao Lee <1838249551@qq.com> --------- Signed-off-by: Hao Lee <1838249551@qq.com> Co-authored-by: cheniujh <1271435567@qq.com>
AlexStocks
reviewed
Nov 20, 2023
AlexStocks
reviewed
Nov 20, 2023
AlexStocks
reviewed
Nov 20, 2023
AlexStocks
reviewed
Nov 20, 2023
AlexStocks
reviewed
Nov 20, 2023
AlexStocks
reviewed
Nov 20, 2023
AlexStocks
reviewed
Nov 20, 2023
AlexStocks
reviewed
Nov 20, 2023
AlexStocks
reviewed
Nov 20, 2023
AlexStocks
reviewed
Nov 20, 2023
AlexStocks
reviewed
Nov 20, 2023
AlexStocks
reviewed
Nov 20, 2023
AlexStocks
reviewed
Nov 20, 2023
AlexStocks
reviewed
Nov 20, 2023
AlexStocks
reviewed
Nov 20, 2023
AlexStocks
reviewed
Nov 20, 2023
AlexStocks
reviewed
Nov 20, 2023
AlexStocks
reviewed
Nov 20, 2023
Signed-off-by: LeeHao <1838249551@qq.com>
* using func instead of class private member
AlexStocks
previously approved these changes
Nov 21, 2023
chejinge
dismissed
AlexStocks’s stale review
November 21, 2023 02:39
The merge-base changed after approval.
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
* Feature/txn (OpenAtomFoundation#1585) * fix: fix select cmd return inconsistent with redis Signed-off-by: Hao Lee <1838249551@qq.com> * refactor:modified lock style while involve db level Signed-off-by: Hao Lee <1838249551@qq.com> * feature:txn basic Signed-off-by: Hao Lee <1838249551@qq.com> * fix:merge upstream Signed-off-by: Hao Lee <1838249551@qq.com> * feature:txn udpate Signed-off-by: Hao Lee <1838249551@qq.com> * feature:add txn for pika(OpenAtomFoundation#1446) todo:test txn. Just to verify the feasibility of the program. Signed-off-by: Hao Lee <1838249551@qq.com> * update unwatch cmd Add comments Signed-off-by: Hao Lee <1838249551@qq.com> * clear watched key when connection closed Signed-off-by: Hao Lee <1838249551@qq.com> * merge upstream code Signed-off-by: Hao Lee <1838249551@qq.com> * update Signed-off-by: Hao Lee <1838249551@qq.com> * feature: add txn for pika completely Signed-off-by: Hao Lee <1838249551@qq.com> * add set txn failed for modified watch key Signed-off-by: Hao Lee <1838249551@qq.com> * update:reduce the particle size of the lock in txn Signed-off-by: Hao Lee <1838249551@qq.com> * chore:remove redundant comment Signed-off-by: Hao Lee <1838249551@qq.com> * test:add go ci test for txn Signed-off-by: Hao Lee <1838249551@qq.com> * fix compile error for linux Signed-off-by: Hao Lee <1838249551@qq.com> * update txn go ci test Signed-off-by: Hao Lee <1838249551@qq.com> * update txn for block list pop command Signed-off-by: Hao Lee <1838249551@qq.com> * Improve blpop-related in Redis transactions Signed-off-by: Hao Lee <1838249551@qq.com> * blpop_txn_fix * add some test for go test txn Signed-off-by: Hao Lee <1838249551@qq.com> * update txn integration test Signed-off-by: Hao Lee <1838249551@qq.com> * txn change class to struct Signed-off-by: Hao Lee <1838249551@qq.com> * txn:use weak ptr instead of shared ptr in Cmd Signed-off-by: Hao Lee <1838249551@qq.com> --------- Signed-off-by: Hao Lee <1838249551@qq.com> Co-authored-by: cheniujh <1271435567@qq.com> * FNT * fix:txn compile error in ubuntu (OpenAtomFoundation#2128) Signed-off-by: LeeHao <1838249551@qq.com> * using func instead of class private member (OpenAtomFoundation#2130) * using func instead of class private member --------- Signed-off-by: Hao Lee <1838249551@qq.com> Signed-off-by: LeeHao <1838249551@qq.com> Co-authored-by: LeeHao <39085999+ForestLH@users.noreply.github.com> Co-authored-by: cheniujh <1271435567@qq.com> Co-authored-by: Xin.Zh <dragoncharlie@foxmail.com>
cheniujh
added a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
* Feature/txn (OpenAtomFoundation#1585) * fix: fix select cmd return inconsistent with redis Signed-off-by: Hao Lee <1838249551@qq.com> * refactor:modified lock style while involve db level Signed-off-by: Hao Lee <1838249551@qq.com> * feature:txn basic Signed-off-by: Hao Lee <1838249551@qq.com> * fix:merge upstream Signed-off-by: Hao Lee <1838249551@qq.com> * feature:txn udpate Signed-off-by: Hao Lee <1838249551@qq.com> * feature:add txn for pika(OpenAtomFoundation#1446) todo:test txn. Just to verify the feasibility of the program. Signed-off-by: Hao Lee <1838249551@qq.com> * update unwatch cmd Add comments Signed-off-by: Hao Lee <1838249551@qq.com> * clear watched key when connection closed Signed-off-by: Hao Lee <1838249551@qq.com> * merge upstream code Signed-off-by: Hao Lee <1838249551@qq.com> * update Signed-off-by: Hao Lee <1838249551@qq.com> * feature: add txn for pika completely Signed-off-by: Hao Lee <1838249551@qq.com> * add set txn failed for modified watch key Signed-off-by: Hao Lee <1838249551@qq.com> * update:reduce the particle size of the lock in txn Signed-off-by: Hao Lee <1838249551@qq.com> * chore:remove redundant comment Signed-off-by: Hao Lee <1838249551@qq.com> * test:add go ci test for txn Signed-off-by: Hao Lee <1838249551@qq.com> * fix compile error for linux Signed-off-by: Hao Lee <1838249551@qq.com> * update txn go ci test Signed-off-by: Hao Lee <1838249551@qq.com> * update txn for block list pop command Signed-off-by: Hao Lee <1838249551@qq.com> * Improve blpop-related in Redis transactions Signed-off-by: Hao Lee <1838249551@qq.com> * blpop_txn_fix * add some test for go test txn Signed-off-by: Hao Lee <1838249551@qq.com> * update txn integration test Signed-off-by: Hao Lee <1838249551@qq.com> * txn change class to struct Signed-off-by: Hao Lee <1838249551@qq.com> * txn:use weak ptr instead of shared ptr in Cmd Signed-off-by: Hao Lee <1838249551@qq.com> --------- Signed-off-by: Hao Lee <1838249551@qq.com> Co-authored-by: cheniujh <1271435567@qq.com> * FNT * fix:txn compile error in ubuntu (OpenAtomFoundation#2128) Signed-off-by: LeeHao <1838249551@qq.com> * using func instead of class private member (OpenAtomFoundation#2130) * using func instead of class private member --------- Signed-off-by: Hao Lee <1838249551@qq.com> Signed-off-by: LeeHao <1838249551@qq.com> Co-authored-by: LeeHao <39085999+ForestLH@users.noreply.github.com> Co-authored-by: cheniujh <1271435567@qq.com> Co-authored-by: Xin.Zh <dragoncharlie@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1446