fix(lists): When using the count optional parameter to execute lpop and rpop, incorrect number of parameters information was returned. - #1639
Merged
Conversation
…nd rpop, incorrect number of parameters information was returned. 1.Added the count private attribute to the rpop and lpop commands, with a default value of 1. 2.If the user passes a count value during the call, the default value is replaced.
![cr-gpt[bot]](https://avatars.githubusercontent.com/in/292659?s=60&v=4){kind=small}
1. Resolved some build error for using lpop in keys_test.cc. 2. For readability,change the type of count_ variable to std::int64_t from int64_t pika_list.h.
# Conflicts: # src/pika_list.cc
AlexStocks
previously approved these changes
Jul 1, 2023
cheniujh
reviewed
Jul 1, 2023
chenbt-hz
reviewed
Jul 2, 2023
…mantics of comments
# Conflicts: # src/pika_list.cc
AlexStocks
approved these changes
Jul 9, 2023
chejinge
approved these changes
Jul 9, 2023
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
…nd rpop, incorrect number of parameters information was returned. (OpenAtomFoundation#1639) * fix(lists): When using the count optional parameter to execute lpop and rpop, incorrect number of parameters information was returned. 1.Added the count private attribute to the rpop and lpop commands, with a default value of 1. 2.If the user passes a count value during the call, the default value is replaced. * fix(keys_tests.h): fix keys_test.cc and refactor pika_list.h. 1. Resolved some build error for using lpop in keys_test.cc. 2. For readability,change the type of count_ variable to std::int64_t from int64_t pika_list.h. * refactor: delete unnecessary variable definitions and optimize the semantics of comments
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
…nd rpop, incorrect number of parameters information was returned. (OpenAtomFoundation#1639) * fix(lists): When using the count optional parameter to execute lpop and rpop, incorrect number of parameters information was returned. 1.Added the count private attribute to the rpop and lpop commands, with a default value of 1. 2.If the user passes a count value during the call, the default value is replaced. * fix(keys_tests.h): fix keys_test.cc and refactor pika_list.h. 1. Resolved some build error for using lpop in keys_test.cc. 2. For readability,change the type of count_ variable to std::int64_t from int64_t pika_list.h. * refactor: delete unnecessary variable definitions and optimize the semantics of comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #1520