Dynamic modification of configuration files&&Slow log by dingxiaoshuai123 · Pull Request #2103 · OpenAtomFoundation/pikiwidb

dingxiaoshuai123 · 2023-11-06T10:16:46Z

Related issue : #2086
1.Add the Codis config command for dynamic configuration at the Codis level.
2. Add slow logging at the Codis level to record commands that exceed the execution time threshold.

…the functionality.

AlexStocks · 2023-11-06T11:20:40Z

+	w := bufio.NewWriter(f)
+
+	for _, item := range c.items {
+		var lineStr string


放到for循环外面

AlexStocks · 2023-11-07T03:14:41Z

 `

 type Config struct {
+	ConfigFileName string `toml:"-" json:"config_file_name"`


1 照配置文件中的顺序放置这些成员，不要上来就放到最上面。
2 为何下面三个成员没有 json?

AlexStocks · 2023-11-07T03:15:11Z

 }
+
+func getWholeCmd(multi []*redis.Resp, cmd []byte) int {
+	var index = 0


var (
index = 0
bytes = 0
)

AlexStocks · 2023-11-07T03:15:27Z

+		}
+		bytes += len(multi[i].Value)
+
+		//  如果cmd已经满了，那么最后腾出来一个more长度的位置添加more信息


改成英文

AlexStocks · 2023-11-07T03:16:52Z

 	"os"
 	"os/exec"
 	"path/filepath"
+	"pika/codis/v2/pkg/proxy/redis"


注意下 import 里面这些包路径的顺序，把这行放到 import 最下面

AlexStocks · 2023-11-07T03:23:05Z

-			log.Errorf("%s remote:%s, start_time(us):%d, duration(us): [%d, %d, %d], %d, tasksLen:%d",
-				time.Unix(r.ReceiveTime/1e9, 0).Format("2006-01-02 15:04:05"), s.Conn.RemoteAddr(), r.ReceiveTime/1e3, d0, d1, d2, duration, r.TasksLen)
-		}
+		//if s.config.SlowlogLogSlowerThan > 0 {


为何注释掉？

AlexStocks · 2023-11-07T03:24:23Z

+
+			r.Resp = SlowLogGetByNum(num)
+		} else if len(r.Multi) == 4 {
+			var id int64


var ( id int64 num int64 err error

)

AlexStocks · 2023-11-07T03:26:06Z

+	PIKA_SLOWLOG_LENGTH_MAX     = 10000000
+)
+
+type Mutex struct {


这种封装有何意义？

AlexStocks · 2023-11-07T03:26:59Z

+		num = int64(PSlowLog.logList.Len())
+	}
+	var res = make([]*redis.Resp, 0, num)
+	var iter = PSlowLog.logList.Front() //  从最新的数据开始


后面的注释改成英文

AlexStocks · 2023-11-07T03:27:39Z

+			return err
+		}
+
+		// 拿到一行并去除两边空白字符


注释全部改成英文

AlexStocks · 2023-11-07T03:27:56Z

+	for i := 0; i < obj.NumField(); i++ {
+		fieldInfo := obj.Type().Field(i)
+		name := fieldInfo.Tag.Get("toml")
+		//  检查字段的toml tag是否合法


改成英文注释

AlexStocks · 2023-11-07T03:28:27Z

+	log.Infof("Show config, len = %d\n", len(c.items))
+	for index, item := range c.items {
+		if item.confType == TypeComment {
+			//  注释的格式:  id: context


改成英文注释

AlexStocks · 2023-11-07T03:28:33Z

+			//  注释的格式:  id: context
+			log.Infof("%d: %s\n", index, item.name)
+		} else {
+			//   配置文件的格式: id: key = value  或者  id: key value


改成英文注释

AlexStocks · 2023-11-07T07:52:19Z

+	}
+}
+
+func (s *Proxy) ConfigSet(key, value string) *redis.Resp {


s 统一改成 p

AlexStocks · 2023-11-07T07:53:50Z

+type DeployConfig struct {
+	items   []*ConfItem
+	confMap map[string]*ConfItem
+	sep     string //配置项中key、value分隔符


英文注释

AlexStocks · 2023-11-08T06:58:28Z

+	if found {
+		item.value = value
+	} else {
+		item := &ConfItem{}


构造函数内赋值

…tion#2103) * Dynamic modification of configuration files.Check the correctness of the functionality. * Modified some specification issues. * Dynamically modify Codis configuration file and add slow query logs.

Dynamic modification of configuration files.Check the correctness of …

788aba2

…the functionality.

AlexStocks reviewed Nov 6, 2023

View reviewed changes

Comment thread codis/pkg/utils/configAux.go Outdated

AlexStocks reviewed Nov 6, 2023

View reviewed changes

Comment thread codis/pkg/utils/configAux.go

AlexStocks reviewed Nov 6, 2023

View reviewed changes

AlexStocks changed the title ~~[wip]Dynamic modification of configuration files.~~ Dynamic modification of configuration files. Nov 7, 2023