Skip to content

Commit 864988a

Browse files
Dynamically modify Codis configuration file and add slow query logs.
1 parent 8f9451e commit 864988a

6 files changed

Lines changed: 189 additions & 186 deletions

File tree

codis/pkg/proxy/config.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,8 +139,6 @@ metrics_report_statsd_prefix = ""
139139
`
140140

141141
type Config struct {
142-
ConfigFileName string `toml:"-" json:"config_file_name"`
143-
144142
ProtoType string `toml:"proto_type" json:"proto_type"`
145143
ProxyAddr string `toml:"proxy_addr" json:"proxy_addr"`
146144
AdminAddr string `toml:"admin_addr" json:"admin_addr"`
@@ -197,6 +195,7 @@ type Config struct {
197195
MetricsReportStatsdServer string `toml:"metrics_report_statsd_server" json:"metrics_report_statsd_server"`
198196
MetricsReportStatsdPeriod timesize.Duration `toml:"metrics_report_statsd_period" json:"metrics_report_statsd_period"`
199197
MetricsReportStatsdPrefix string `toml:"metrics_report_statsd_prefix" json:"metrics_report_statsd_prefix"`
198+
ConfigFileName string `toml:"-" json:"config_file_name"`
200199
}
201200

202201
func NewDefaultConfig() *Config {

codis/pkg/proxy/mapper.go

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ func init() {
7373
{"BLPOP", FlagWrite | FlagNotAllow},
7474
{"BRPOP", FlagWrite | FlagNotAllow},
7575
{"BRPOPLPUSH", FlagWrite | FlagNotAllow},
76-
{"CCONFIG", FlagWrite},
7776
{"CLIENT", FlagNotAllow},
7877
{"CLUSTER", FlagNotAllow},
7978
{"COMMAND", 0},
@@ -216,7 +215,7 @@ func init() {
216215
{"SLOTSRESTORE-ASYNC-AUTH", FlagWrite | FlagNotAllow},
217216
{"SLOTSRESTORE-ASYNC-ACK", FlagWrite | FlagNotAllow},
218217
{"SLOTSSCAN", FlagMasterOnly},
219-
{"SLOWLOG", 0},
218+
{"SLOWLOG", FlagNotAllow},
220219
{"SMEMBERS", 0},
221220
{"SMOVE", FlagWrite},
222221
{"SORT", FlagWrite},
@@ -230,6 +229,8 @@ func init() {
230229
{"SUNION", 0},
231230
{"SUNIONSTORE", FlagWrite},
232231
{"SYNC", FlagNotAllow},
232+
{"PCONFIG", 0},
233+
{"PSLOWLOG", 0},
233234
{"TIME", FlagNotAllow},
234235
{"TOUCH", FlagWrite},
235236
{"TTL", 0},
@@ -322,9 +323,10 @@ func getHashKey(multi []*redis.Resp, opstr string) []byte {
322323
}
323324

324325
func getWholeCmd(multi []*redis.Resp, cmd []byte) int {
325-
var index = 0
326-
var bytes = 0
327-
326+
var (
327+
index = 0
328+
bytes = 0
329+
)
328330
for i := 0; i < len(multi); i++ {
329331
if index < len(cmd) {
330332
index += copy(cmd[index:], multi[i].Value)
@@ -334,7 +336,6 @@ func getWholeCmd(multi []*redis.Resp, cmd []byte) int {
334336
}
335337
bytes += len(multi[i].Value)
336338

337-
// 如果cmd已经满了,那么最后腾出来一个more长度的位置添加more信息
338339
if i == len(multi)-1 && index == len(cmd) {
339340
more := []byte("... " + strconv.Itoa(len(multi)) + " elements " + strconv.Itoa(bytes) + " bytes.")
340341
index = len(cmd) - len(more)

0 commit comments

Comments
 (0)