Skip to content

[php-nextgen] Check for $openApiType === "string" instead of "\DateTime" in ObjectSerializer#23937

Merged
wing328 merged 1 commit into
OpenAPITools:masterfrom
wbohlken:fix/date-time-openapi-type-php-nextgen
Jun 4, 2026
Merged

[php-nextgen] Check for $openApiType === "string" instead of "\DateTime" in ObjectSerializer#23937
wing328 merged 1 commit into
OpenAPITools:masterfrom
wbohlken:fix/date-time-openapi-type-php-nextgen

Conversation

@wbohlken

@wbohlken wbohlken commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

ObjectSerializer incorretly validates the $openApiType equals \DateTime. This is not a valid OpenAPI type, instead, it should validate the type to be string.

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wbohlken
wbohlken force-pushed the fix/date-time-openapi-type-php-nextgen branch 2 times, most recently from ebf4dda to cbea9db Compare June 3, 2026 15:26

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@wbohlken

wbohlken commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

@wbohlken
wbohlken force-pushed the fix/date-time-openapi-type-php-nextgen branch from cbea9db to 69cbd92 Compare June 3, 2026 15:39
@wing328 wing328 added this to the 7.23.0 milestone Jun 4, 2026
@wing328

wing328 commented Jun 4, 2026

Copy link
Copy Markdown
Member

lgtm. let's give it a try

thanks for the contribution.

@wing328
wing328 merged commit 2b76ca1 into OpenAPITools:master Jun 4, 2026
23 checks passed
@wing328

wing328 commented Jun 4, 2026

Copy link
Copy Markdown
Member

By the way your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants