[Rust-Axum] Fix compilation error when validate is used on Nullable values - #20100
Merged
wing328 merged 4 commits intoNov 15, 2024
Conversation
Victoria-Casasampere-BeeTheData
marked this pull request as ready for review
November 14, 2024 03:47
Member
|
@Victoria-Casasampere-BeeTheData thanks for the PR cc @linxGnu |
linxGnu
suggested changes
Nov 14, 2024
Victoria-Casasampere-BeeTheData
force-pushed
the
rust-axum-nullable-validator
branch
from
November 14, 2024 09:42
9f721a6 to
66aaf19
Compare
linxGnu
approved these changes
Nov 14, 2024
linxGnu
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thank you so much @Victoria-Casasampere-BeeTheData
Contributor
|
@Victoria-Casasampere-BeeTheData Please ensure that the integration test passed. You can use following command: mvn clean && ./bin/generate-samples.sh bin/configs/manual/rust-axum-* && mvn integration-test -f samples/server/petstore/rust-axum/pom.xml |
Contributor
|
@wing328 Please merge this PR. Thank you! |
Victoria-Casasampere-BeeTheData
deleted the
rust-axum-nullable-validator
branch
November 15, 2024 15:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes different compilation errors that can occur when
Validateis derived in structures that useNullablein its fields. This has been done in the same way as the library implementation of the different traits inOption.Updating the library was necessary to have access to
validator::AsRegex.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples, as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)