Skip to content

SWIFT5: sort query items alphabetically to allow better server side caching of requests with same URL - #18239

Merged
4brunu merged 2 commits into
OpenAPITools:masterfrom
mbruegmann:swift5-sorted-URLQueryItems
Apr 5, 2024
Merged

SWIFT5: sort query items alphabetically to allow better server side caching of requests with same URL#18239
4brunu merged 2 commits into
OpenAPITools:masterfrom
mbruegmann:swift5-sorted-URLQueryItems

Conversation

@mbruegmann

@mbruegmann mbruegmann commented Mar 27, 2024

Copy link
Copy Markdown
Contributor

Currently query items in a request have random ordering that can change with every request.
For example we see

/geolocations?latitude=52.519&longitude=13.408
and
/geolocations?longitude=13.408&latitude=52.519

To allow caching based on same URLs this PR takes care of ordering the query items alphabetically.
This should not have any impact on backward compatibility, because no installation will require a random ordering.

@dydus0x14

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328

wing328 commented Apr 5, 2024

Copy link
Copy Markdown
Member

cc
@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11) @dydus0x14 (2023/06)

@4brunu
4brunu merged commit 90301f9 into OpenAPITools:master Apr 5, 2024
@wing328 wing328 added this to the 7.5.0 milestone Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants