Specify named param for field defaults in Python Pydantic V1 generator - #18187
Merged
Conversation
Member
|
thanks for the PR. please follow step 3 to update the samples |
Contributor
Author
|
Apologies forgot to push, done |
Member
|
thanks for the PR. let's give it a try |
Member
|
have you considered migrating to python-pydantic-v1 will eventually be sunset. |
Contributor
Author
That would require migrating our whole codebase to pydantic v2, which is prohibitively annoying at this stage (we do want to do it). The embedded v1 in the v2 package isn't 100% compatible for us sadly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type-checkers like pyright require the Field-default by the dataclass decorator to be a named parameter. Using the positional variant will result in it being considered a required parameter.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)@cbornet @tomplus @krjakbrjak @fa0311 @multani