Skip to content

feat(php): drop support for EOLed PHP versions and unify min required version - #17826

Merged
wing328 merged 1 commit into
OpenAPITools:masterfrom
simPod:php/eol
Mar 24, 2025
Merged

feat(php): drop support for EOLed PHP versions and unify min required version#17826
wing328 merged 1 commit into
OpenAPITools:masterfrom
simPod:php/eol

Conversation

@simPod

@simPod simPod commented Feb 8, 2024

Copy link
Copy Markdown
Contributor

Anything under php v8.1 is EOLed.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@simPod
simPod requested a review from jimschubert as a code owner February 8, 2024 13:57
@simPod

simPod commented Feb 8, 2024

Copy link
Copy Markdown
Contributor Author

@jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ybelenko (2018/07), @renepardon (2018/12)

@wing328 wing328 added this to the 8.0.0 milestone Feb 12, 2024
@wing328

wing328 commented Feb 12, 2024

Copy link
Copy Markdown
Member

as discussed, we will include this change in the upcoming v8.0.0 major release later.

Comment thread samples/client/petstore/php-dt/README.md Outdated
@wing328

wing328 commented Mar 24, 2025

Copy link
Copy Markdown
Member

thanks for the PR. just merged it to the master

if anyone needs a rollback for whatever reason, we will consider adding an option.

@simPod
simPod deleted the php/eol branch March 24, 2025 07:23
@simPod

simPod commented Mar 24, 2025

Copy link
Copy Markdown
Contributor Author

Cool thanks! Old versions still support dead PHPs, anyone can use those.

I planed some improvements for php in the past, will try to remember what those were and send PR eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants