Skip to content

Normalize emitted ctrace reference data types - #41

Merged
JonatanAntoni merged 3 commits into
mainfrom
copilot/review-emitted-data-type-values
Sep 3, 2026
Merged

Normalize emitted ctrace reference data types#41
JonatanAntoni merged 3 commits into
mainfrom
copilot/review-emitted-data-type-values

Conversation

Copilot AI commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

ctrace-ref.data-type could receive DWARF-derived categories outside the supported signed, unsigned, and float values.

  • Emission normalization
    • Preserve supported values.
    • Emit unsigned for every other type.
    • Add info with the actual discovered symbol type.
data-type: unsigned
info: "data-type defaulted to unsigned for symbol type 'pointer'"
  • Regression coverage
    • Covers preservation of all supported values.
    • Updates fallback expectations for func and object, including generation-failure paths.

Copilot AI linked an issue Sep 1, 2026 that may be closed by this pull request
Co-authored-by: JonatanAntoni <25795816+JonatanAntoni@users.noreply.github.com>
Copilot AI changed the title [WIP] Restrict data-type output to unsigned, signed, or float Normalize emitted ctrace reference data types Sep 1, 2026
Copilot AI requested a review from JonatanAntoni September 1, 2026 15:08
@JonatanAntoni
JonatanAntoni marked this pull request as ready for review September 1, 2026 15:37
@qltysh

qltysh Bot commented Sep 1, 2026

Copy link
Copy Markdown

Qlty


Coverage Impact

This PR will not change total coverage.

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
src/pyts/coresight/generator.py100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Comment thread src/pyts/coresight/generator.py
@JonatanAntoni
JonatanAntoni merged commit 9e73701 into main Sep 3, 2026
13 checks passed
@JonatanAntoni
JonatanAntoni deleted the copilot/review-emitted-data-type-values branch September 3, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review emitted data-type values

3 participants