Fix leak on failure to load renderable#408
Merged
OneLoneCoder merged 1 commit intoJun 22, 2025
Merged
Conversation
…ointer. This caused a leak when a Renderable which already has an image loaded tries to load an image, but fails to do so.
Owner
|
yeah good spot, i guess reset() would also be appropriate but yeah |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The line removed had it's return value discarded. The return value is an owning raw pointer to a sprite just created by the function, so discarding it caused a leak. This code was used to test it:
Before the change, a slow but steady increase in memory would happen with the previous code. After letting it run for a few minutes, the program reached 500 MB of used memory. After the change, no such increase in memory, and the same program takes 95 MB no matter how long it ran for.