Feature/alt syntax#7
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces an experimental computation-expression based rule definition syntax (notably command) and adds coverage to validate “always run” command behavior across engine/script invocations and concurrent demands.
Changes:
- Added
Xake.Experimental.RuleBuilderprovidingcommand/target/targetsbuilders, withcommandinjectingAlwaysRerun. - Refactored sequential dependency building into a
needSequentiallyhelper and reused it in the<<<operator. - Added
CommandTestsand wired it into the test project to cover command rerun/dedup/serialization behaviors.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tests/tests.fsproj | Includes new CommandTests.fs in the test project build. |
| src/tests/CommandTests.fs | Adds NUnit tests for command “always run” semantics and concurrency behaviors. |
| src/core/Xake.fsproj | Includes new core source file RuleBuilder.fs. |
| src/core/ScriptFuncs.fs | Adds needSequentially helper and updates <<< to call it. |
| src/core/RuleBuilder.fs | Adds experimental CE builders for command/target/targets. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…tially` (#8) * Initial plan * Fix XML doc comment placement: move needSequentially above the <== doc block Co-authored-by: OlegZee <513301+OlegZee@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: OlegZee <513301+OlegZee@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements yet another syntax for defining rules and introduces command which has builtin "always run" behavior i.e. is executed on every call