Skip to content

[FIX/ADD] configuration options#86

Merged
guewen merged 2 commits into
OCA:11.0from
nilshamerlinck:11.0_-_queue_job_-_configuration_options
Jul 30, 2018
Merged

[FIX/ADD] configuration options#86
guewen merged 2 commits into
OCA:11.0from
nilshamerlinck:11.0_-_queue_job_-_configuration_options

Conversation

@nilshamerlinck

@nilshamerlinck nilshamerlinck commented Jul 26, 2018

Copy link
Copy Markdown
Contributor
  1. 652911b re-introduced an harcoded http://localhost ;-)
  2. Port of [ADD] configurable db host and port connector#248

@coveralls

coveralls commented Jul 26, 2018 •
edited
Loading

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.5%) to 78.287% when pulling c01ddf8 on nilshamerlinck:11.0_-queue_job-_configuration_options into ea36bbf on OCA:11.0.

@guewen

guewen commented Jul 27, 2018

Copy link
Copy Markdown
Member

652911b re-introduced an harcoded http://localhost ;-)

Oops, sorry 😑

guewen
guewen approved these changes Jul 27, 2018
View reviewed changes

@guewen guewen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guewen

guewen commented Jul 27, 2018

Copy link
Copy Markdown
Member

Only a few lint from travis to fix:

queue_job/jobrunner/runner.py:29:80: E501 line too long (96 > 79 characters)
queue_job/jobrunner/runner.py:33:80: E501 line too long (94 > 79 characters)
queue_job/jobrunner/runner.py:34:80: E501 line too long (89 > 79 characters)

simahawk
simahawk approved these changes Jul 27, 2018
View reviewed changes

@simahawk simahawk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, I'd replace a var name, but that's it :)
tnx for the change!

Comment thread queue_job/jobrunner/runner.py
def _connection_info_for(db_name):
db_or_uri, connection_info = odoo.sql_db.connection_info_for(db_name)

for p in ('host', 'port'):

@simahawk simahawk Jul 27, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/p/[key|param]

@nilshamerlinck nilshamerlinck Jul 27, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't mind, I will keep it as it to keep it consistent with the same piece of code that is in the other versions of the module.

@simahawk simahawk Jul 27, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, sorry, I missed the original code 😅 👍

@nilshamerlinck nilshamerlinck force-pushed the 11.0_-_queue_job_-_configuration_options branch from a96e0de to c01ddf8 Compare July 27, 2018 12:55
@guewen guewen merged commit 069456f into OCA:11.0 Jul 30, 2018
@whulshof

whulshof commented Aug 2, 2018

Copy link
Copy Markdown

Could this merge cause queue to not start anymore? I took the latest 10.0 merge and deployed it in my test-environment and now no jobs will start anymore. In the log the job runner gives the usual acknowledgement it runs on the db etc.
Should I change any configuration to get it running again? Which I would think is not to be expected, but anyhow.

@nilshamerlinck

nilshamerlinck commented Aug 2, 2018

Copy link
Copy Markdown
Contributor Author

Hi @whulshof, the PR for 10.0 is #77

Any error message? Are you using a connection pooler (pgbouncer)?

@whulshof

whulshof commented Aug 2, 2018 via email

Copy link
Copy Markdown

@sbidoul

sbidoul commented Aug 2, 2018

Copy link
Copy Markdown
Member

A common cause for jobs not starting is jobs in remaining in state enqueued or started when the server has not been shut down properly.

@whulshof

whulshof commented Aug 2, 2018 via email

Copy link
Copy Markdown

@lmignon

lmignon commented Aug 2, 2018

Copy link
Copy Markdown
Contributor

@whulshof do you have more than 1 database visible by your Odoo instance? If it's the case, can you retry with only 1 database visible by odoo?

@whulshof

whulshof commented Aug 2, 2018 via email

Copy link
Copy Markdown

@whulshof

whulshof commented Aug 2, 2018 via email

Copy link
Copy Markdown

@repodevs repodevs mentioned this pull request Nov 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simahawk simahawk simahawk approved these changes
@guewen guewen guewen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@nilshamerlinck @coveralls @guewen @whulshof @sbidoul @lmignon @simahawk